Blender Git Loki

Cleanup: Remove unecessary helper function

Retrieving a mesh's looptris now take's a const mesh after
rB5f8969bb4b4, which removes the need for this function.
Since it's only two lines, avoiding the use of a separate function
in this case is simpler.

Cleanup: Use const mesh arguments

These functions do not change their source or input mesh, so it can
be passed with const, which means in one case that a function doesn't
have to be responsible for freeing its argument mesh, which is a clearly
better separation of concerns.

Cleanup: Remove unused includes

Cleanup: Voxel remesh function naming

- Remove BKE prefix for static functions
- Make specific intermediate functions static
- Avoid unecessary "_to_mesh_nomain" suffix

LineArt: Fix(unreported): Child object respect collection visibility.

Cleanup: Reorder functions

The Quadriflow remeshing was in the middle of the voxel remesh code.

LineArt: Material flag versioning correction.

By the patch made it in master the version value already advanced (see https://developer.blender.org/D11839), so this versioning code needs to be moved down to that point.

UI: Show a notification when saving preferences

So far the only way to know if they were saved properly was
to check the terminal.

Also notify when preferences fail to save.

Cleanup: Simplify logic, follow style guide for integer types

- Use `int` instead of `unsigned int` for mesh indices
- Use C++ types (Array, float3, IndexRange)
- Use range based for loops

Fix build error in debug builds and uninitialized structs

This BMesh iterator hadn't been used in C++ code yet, and needed
a macro for a proper cast. The parameter structs need to be initialized
when declared without designated initializers.

Compositor: Fix wrong number of threads during constant folding

The variable was uninitialized at that point of execution.

Cleanup: unneeded default constructor definitions

Compositor: Buffer iterators tests

See D11882 for a description of the iterators.

Reviewed By: jbakker

Differential Revision: https://developer.blender.org/D12001

Assets: Rename "Mark Asset" operator to "Mark as Asset"

This naming change was agreed on during the asset workshop. See
https://code.blender.org/2021/06/asset-browser-workshop-outcomes/#terms-definitions.

UI: Move Mark/Clear asset out of ID Data in Outliner context menu

They are now always shown in the top-level of the Outliner context menu.
Having them in the ID Data submenu was just a hassle to work with, and
often confusing to users - even if technically correct (the asset status
is part of the ID data).

Part of T82680.

Cleanup: Move remesh files to C++

This will be helpful for some cleanups I'd like to do, including
removing the unecessary C API for OpenVDB and unifying some
attribute transfer code.

Fix incorrect poll function used for file path dropping

The operator to drop file paths into the File Browser was just checking
if there's an active window. This wasn't really an issue since the
operator was only used as drop-operator for the File Browser. But the
operator would show up in the operator search. Plus, for asset browsing,
we'll also have to check the file browsing mode, so the more specific
poll function will be needed.

Assets: Disable File Browser only operators for asset browsing

These operators shouldn't be available in the Asset Browser.

https://developer.blender.org/T83556

Added a comment to each operator poll assignment to explicitly mention
the intention. That should also remind devs to decide if the operator
should apply for both file & asset browsing when copy & pasting operator
definition code.

Cleanup: clarify license and origin of voronoi and dithering code

Cleanup: compiler warnings