Blender Git Loki

Git Commits -> Revision bc1e675

Revision bc1e675 by Sergey Sharybin (master)
September 22, 2021, 15:10 (GMT)
Fix T91603: Cycles crash when volume becomes visible

Making object which uses volume shader invisible will mark the shader
as not having a volume, forcing re-compilation of the shader to bring
it back to a consistent state.

The compilation is happening as part of scene update, which needs to
know kernel features. So there is a feedback loop.

Use more relaxed way of knowing whether there is a volume in the
shader for the kernel features, which doesn't require shader to be
compiled first.

Solves issues from the report, but potentially causes extra memory
allocated if the volume part of graph is fully optimized out. This
downside is solvable, but would need to split scene update into two
steps (the one which requires on kernel, and the one which does not).
It will be an interesting project to tackle, but for a bug fix is
better to use simpler solution.

Commit Details:

Full Hash: bc1e675bb905baec73f2758b009826530678e436
Parent Commit: 1eba32c
Lines Changed: +1, -1

1 Modified Path:

/intern/cycles/render/shader.cpp (+1, -1) (Diff)
Tehnyt: Miika HämäläinenViimeksi päivitetty: 07.11.2014 14:18MiikaH:n Sivut a.k.a. MiikaHweb | 2003-2021