Blender Git Loki
Git Commits -> Revision 2bd9f9d
Revision 2bd9f9d by Julian Eisel (master) April 12, 2021, 16:48 (GMT) |
UI/Nodes: Improve feedback when adding node fails (e.g. on drag & drop) This is especially useful when trying to add a node group instance, e.g. via drag & drop from the Outliner or Asset Browser. Previously this would just silently fail, with no information why. This is a source of confusion, e.g. earlier, it took me a moment to realize I was dragging a node group into itself, which failed of course. Blender should always try to help the user with useful error messages. Adds error messages like: "Nesting a node group inside of itself is not allowed", "Not a compositor node tree", etc. Adds a disabled hint return argument to node and node tree polling functions. On error the hint is reported, or could even be shown in advance (e.g. if checked via an operator poll option). Differential Revision: https://developer.blender.org/D10422 Reviewed by: Jacques Lucke |
Commit Details:
Full Hash: 2bd9f9d976560c55a15ed297032f7d73c2f101cc
Parent Commit: cbd1932
Lines Changed: +224, -79
21 Modified Paths:
/source/blender/blenkernel/BKE_node.h (+19, -5) (Diff)
/source/blender/blenkernel/intern/node.cc (+10, -5) (Diff)
/source/blender/editors/space_node/node_add.c (+19, -1) (Diff)
/source/blender/editors/space_node/node_edit.c (+18, -6) (Diff)
/source/blender/editors/space_node/node_group.c (+13, -2) (Diff)
/source/blender/editors/space_node/node_templates.c (+8, -3) (Diff)
/source/blender/makesrna/intern/rna_nodetree.c (+36, -16) (Diff)
/source/blender/nodes/composite/nodes/node_composite_cryptomatte.cc (+8, -1) (Diff)
/source/blender/nodes/composite/nodes/node_composite_image.c (+21, -13) (Diff)
/source/blender/nodes/composite/node_composite_util.c (+8, -2) (Diff)
/source/blender/nodes/composite/node_composite_util.h (+3, -1) (Diff)
/source/blender/nodes/function/node_function_util.cc (+8, -2) (Diff)
/source/blender/nodes/function/node_function_util.hh (+0, -1) (Diff)
/source/blender/nodes/geometry/node_geometry_util.cc (+8, -2) (Diff)
/source/blender/nodes/geometry/node_geometry_util.hh (+3, -1) (Diff)
/source/blender/nodes/intern/node_common.c (+11, -9) (Diff)
/source/blender/nodes/intern/node_common.h (+3, -1) (Diff)
/source/blender/nodes/shader/node_shader_util.c (+14, -4) (Diff)
/source/blender/nodes/shader/node_shader_util.h (+3, -1) (Diff)
/source/blender/nodes/texture/node_texture_util.c (+8, -2) (Diff)
/source/blender/nodes/texture/node_texture_util.h (+3, -1) (Diff)
/source/blender/blenkernel/intern/node.cc (+10, -5) (Diff)
/source/blender/editors/space_node/node_add.c (+19, -1) (Diff)
/source/blender/editors/space_node/node_edit.c (+18, -6) (Diff)
/source/blender/editors/space_node/node_group.c (+13, -2) (Diff)
/source/blender/editors/space_node/node_templates.c (+8, -3) (Diff)
/source/blender/makesrna/intern/rna_nodetree.c (+36, -16) (Diff)
/source/blender/nodes/composite/nodes/node_composite_cryptomatte.cc (+8, -1) (Diff)
/source/blender/nodes/composite/nodes/node_composite_image.c (+21, -13) (Diff)
/source/blender/nodes/composite/node_composite_util.c (+8, -2) (Diff)
/source/blender/nodes/composite/node_composite_util.h (+3, -1) (Diff)
/source/blender/nodes/function/node_function_util.cc (+8, -2) (Diff)
/source/blender/nodes/function/node_function_util.hh (+0, -1) (Diff)
/source/blender/nodes/geometry/node_geometry_util.cc (+8, -2) (Diff)
/source/blender/nodes/geometry/node_geometry_util.hh (+3, -1) (Diff)
/source/blender/nodes/intern/node_common.c (+11, -9) (Diff)
/source/blender/nodes/intern/node_common.h (+3, -1) (Diff)
/source/blender/nodes/shader/node_shader_util.c (+14, -4) (Diff)
/source/blender/nodes/shader/node_shader_util.h (+3, -1) (Diff)
/source/blender/nodes/texture/node_texture_util.c (+8, -2) (Diff)
/source/blender/nodes/texture/node_texture_util.h (+3, -1) (Diff)
Master Commits
MiikaH:n Sivut a.k.a. MiikaHweb | 2003-2021