Blender Git Loki

Git Commits -> Revision 18392ce

Revision 18392ce by Hans Goudey (master)
November 2, 2021, 20:16 (GMT)
Fix T92652: Joining curves breaks point attribute order

Currently the curve to mesh node relies on the order of attributes being
the same on every spline. This is a worthwhile assumption, because it
will allow removing the attribute name storage duplication on every
spline in the future.

However, the join geometry node broke this order, since it just created
new attributes without any regard to the order. To fix this, I added a
"reorder" step after all the merged attributes have been created, the
types have been joined, etc. It should be possible to change this code
so that the attributes are added with the right order in the first
place, but I would like to do that after refactoring spline attribute
storage, and not for 3.0.

Differential Revision: https://developer.blender.org/D13074

Commit Details:

Full Hash: 18392cef17ddb40857fdb2462d8bad50f389029b
Parent Commit: 7aa311e
Lines Changed: +64, -0

4 Modified Paths:

/source/blender/blenkernel/BKE_attribute_access.hh (+5, -0) (Diff)
/source/blender/blenkernel/intern/attribute_access.cc (+20, -0) (Diff)
/source/blender/blenkernel/intern/geometry_set_instances.cc (+19, -0) (Diff)
/source/blender/nodes/geometry/nodes/node_geo_join_geometry.cc (+20, -0) (Diff)
Tehnyt: Miika HämäläinenViimeksi päivitetty: 07.11.2014 14:18MiikaH:n Sivut a.k.a. MiikaHweb | 2003-2021