Blender Git Commit Log

Git Commits -> Revision fdc1a1c

January 31, 2018, 01:10 (GMT)
Cleanup: Move private/internal operator state data out of public header for GPencil module

This commit moves the defines for several modal operators
(Interpolate, Fill, and Add Primitives) out of the editors/gpencil
module's public headerfile ("ED_gpencil.h") into the module's
internal headerfile ("gpencil_intern.h").

We should not be spraying the internal implementation details of
operators in public headers. In this case, these defines weren't
even being used outside of the gpencil module - they were only
put in a header so that drawgpencil.c (which lives in the same
module) could access this data (and even then, I wonder those
callbacks need access to everything).

Note: I couldn't get rid of the ED_numinput.h include in the header
yet, as several of the operators define NumInput members inline.

Commit Details:

Full Hash: fdc1a1c06b82af264d026620f45fa6e3948237c1
Parent Commit: 833afb7
Lines Changed: +182, -165

3 Modified Paths:

/source/blender/editors/gpencil/drawgpencil.c (+2, -0) (Diff)
/source/blender/editors/gpencil/gpencil_intern.h (+171, -0) (Diff)
/source/blender/editors/include/ED_gpencil.h (+9, -165) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021