Blender Git Commit Log

Git Commits -> Revision f17dcf5

Revision f17dcf5 by Brecht Van Lommel (master)
March 16, 2010, 16:58 (GMT)
Fixes for thread related render / compositing crashes:

* Viewer node could free image while it is being redrawn, viewer image
buffers now need acquire/release to be accessed as was already the
case for render results.
* The Composite node could free the image buffers outside of a lock,
also causing simultaneous redraw to crash.
* Especially on Windows, re-rendering could crash when drawing an image
that was freed. When RE_RenderInProgress was true it would access the
image buffer and simply return it while it could still contain a pointer
to a render result buffer that was already freed. I don't understand
why this case was there in the first place, so I've removed it.

Possibly fixes bugs #20174, #21418, #21391, #21394.

Commit Details:

Full Hash: f17dcf58c86274661a10cf4f95939deb63a02fa7
SVN Revision: 27541
Parent Commit: 735b444
Lines Changed: +106, -114

6 Modified Paths:

/source/blender/blenkernel/intern/image.c (+90, -101) (Diff)
/source/blender/blenlib/BLI_threads.h (+2, -1) (Diff)
/source/blender/blenlib/intern/threads.c (+5, -0) (Diff)
/source/blender/nodes/intern/CMP_nodes/CMP_composite.c (+2, -2) (Diff)
/source/blender/nodes/intern/CMP_nodes/CMP_viewer.c (+5, -1) (Diff)
/source/blender/render/intern/source/pipeline.c (+2, -9) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021