Blender Git Commit Log

Git Commits -> Revision 7a92b88

Revision 7a92b88 by Brecht Van Lommel (master)
April 24, 2019, 12:39 (GMT)
Cycles: remove hair minimum width support.

This never really worked as it was supposed to. The main goal of this is to
turn noise from sampling tiny hairs into multiple layers of transparency that
do not need to be sampled stochastically. However the implementation of this
worked by randomly discarding hair intersections in BVH traversal, which
defeats the purpose.

If it ever comes back, it's best implemented outside the kernel as a preprocess
that changes hair radius before BVH building. This would also make it work with
Embree, where it's not supported now. But it's not so clear anymore that with
many AA samples and GPU rendering this feature is as helpful as it once was for
CPU raytracers with few AA samples.

The benefit of removing this feature is improved hair ray tracing performance,
tested on NVIDIA Titan Xp:

bmw27: +0.37%
classroom: +0.26%
fishy_cat: -7.36%
koro: -12.98%
pabellon: -0.12%

Differential Revision: https://developer.blender.org/D4532

Commit Details:

Full Hash: 7a92b8820b9661af39165f048d716559e513ddab
Parent Commit: 5f888e6
Lines Changed: +52, -1128

22 Modified Paths:

/intern/cycles/blender/addon/properties.py (+0, -14) (Diff)
/intern/cycles/blender/addon/ui.py (+0, -2) (Diff)
/intern/cycles/blender/blender_curves.cpp (+0, -2) (Diff)
/intern/cycles/kernel/bvh/bvh.h (+5, -8) (Diff)
/intern/cycles/kernel/bvh/bvh_nodes.h (+0, -310) (Diff)
/intern/cycles/kernel/bvh/bvh_shadow_all.h (+2, -8) (Diff)
/intern/cycles/kernel/bvh/bvh_traversal.h (+9, -115) (Diff)
/intern/cycles/kernel/bvh/bvh_types.h (+0, -1) (Diff)
/intern/cycles/kernel/bvh/obvh_nodes.h (+0, -181) (Diff)
/intern/cycles/kernel/bvh/obvh_shadow_all.h (+2, -8) (Diff)
/intern/cycles/kernel/bvh/obvh_traversal.h (+5, -68) (Diff)
/intern/cycles/kernel/bvh/qbvh_nodes.h (+0, -187) (Diff)
/intern/cycles/kernel/bvh/qbvh_shadow_all.h (+2, -8) (Diff)
/intern/cycles/kernel/bvh/qbvh_traversal.h (+5, -68) (Diff)
/intern/cycles/kernel/geom/geom_curve_intersect.h (+14, -107) (Diff)
/intern/cycles/kernel/kernel_path.h (+1, -19) (Diff)
/intern/cycles/kernel/kernel_shadow.h (+4, -8) (Diff)
/intern/cycles/kernel/kernel_types.h (+1, -2) (Diff)
/intern/cycles/kernel/osl/osl_services.cpp (+1, -1) (Diff)
/intern/cycles/kernel/svm/svm_ao.h (+1, -1) (Diff)
/intern/cycles/render/curves.cpp (+0, -7) (Diff)
/intern/cycles/render/curves.h (+0, -3) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021