Blender Git Commit Log

Git Commits -> Revision 7887e91

Revision 7887e91 by Sybren A. Stüvel (master)
November 2, 2020, 14:36 (GMT)
Cleanup: Sanitise return value of `ED_object_parent_set()`

Consistently return `false` from `ED_object_parent_set()` when parenting
is not possible. Before, when parent and child were the same object, the
function would return `true` even though the parent-child relation was
not made.

Just returning `false` in the `parent == child` case would break the
parenting operator, as `false` stops its loop over all selected objects.
This tight coupling caused T82312. The loop now has its own check for
this, so that it properly continues, and the implementation of
`ED_object_parent_set()` is decoupled from its surrounding code.

No functional changes.

Commit Details:

Full Hash: 7887e91d316567366e99fb0d066861cb89ae5816
Parent Commit: 417ba6a
Lines Changed: +14, -1

2 Modified Paths:

/source/blender/editors/include/ED_object.h (+1, -0) (Diff)
/source/blender/editors/object/object_relations.c (+13, -1) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021