Blender Git Commit Log

Git Commits -> Revision 64f5afd

Revision 64f5afd by Ray molenkamp (master)
January 25, 2017, 16:37 (GMT)
[Cycles/MSVC/Testing] Fix broken test code.

Currently the tests don't run on windows for the following reasons

1) render_graph_finalize has an linking issue due missing a bunch of libraries (not sure why this is not an issue for linux)
2) This one is more interesting, in test/python/cmakelists.txt ${TEST_BLENDER_EXE_BARE} and ${TEST_BLENDER_EXE} are flat out wrong, but for some reason this doesn't matter for most tests, cause ctest will actually go out and look for the executable and fix the path for you *BUT* only for the command, if you use them in any of the parameters it'll happily pass on the wrong path.
3) on linux you can just run a .py file, windows is not as awesome and needs to be told to run it with pyton.
4) had to use the NAME/COMMAND long form of add_test otherwise $<TARGET_FILE:blender> doesn't get expanded, why? beats me.
5) missing idiff.exe for msvc2015/x64 in the libs folder.

This patch addresses 1-4 , but given I have no working Linux build environment, I'm unsure if it'll break anything there

5 has been fixed in rBL61751

Reviewers: juicyfruit, brecht, sergey

Reviewed By: sergey

Subscribers: Blendify

Tags: #cycles, #automated_testing

Differential Revision: https://developer.blender.org/D2367

Commit Details:

Full Hash: 64f5afdb89bbf3831e97d76a178acee1d9524452
Parent Commit: e5482f9
Lines Changed: +53, -38

9 Modified Paths:

/build_files/cmake/macros.cmake (+0, -7) (Diff)
/build_files/cmake/Modules/GTestTesting.cmake (+1, -1) (Diff)
/build_files/cmake/platform/platform_win32_msvc.cmake (+8, -4) (Diff)
/intern/cycles/test/CMakeLists.txt (+13, -2) (Diff)
/make.bat (+5, -2) (Diff)
/tests/gtests/blenlib/BLI_string_test.cc (+1, -1) (Diff)
/tests/gtests/CMakeLists.txt (+3, -0) (Diff)
/tests/gtests/testing/CMakeLists.txt (+0, -3) (Diff)
/tests/python/CMakeLists.txt (+22, -18) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021