Blender Git Commit Log

Git Commits -> Revision 50e9868

Revision 50e9868 by Antonis Ryakiotakis (master)
February 24, 2015, 16:19 (GMT)
Fix T43785 crash with border select.

Naming here is slightly misleading. We have:

* Number of elements (objects) that can be picked
* Buffer size
* Number of integers in buffer.

Interestingly enough, bufsize in OpenGL (as far as I could find in
examples on the web) and in most of the code refers to the latter and
actual buffer size is only used whenever we do allocations on the heap.
Added an extra defines here to make things a bit clearer:

* MAXPICKELEMS refers to the number of objects that can be picked
* MAXPICKBUF refers to the number of integers in the selection buffer

Also made all buffers use MAXPICKBUF where some used MAXPICKBUF * 4.
That means that some parts of blender will use less space for selection
now. MAXPICKBUF is set to 10000 for 2500 object selection, which can be
changed at any time, but I think 10000 integers on the stack touches the
borders of uglyland anyway.

Commit Details:

Full Hash: 50e9868abe11bd2ed0173b7a51cf129d77e4389e
Parent Commit: 340b76b
Lines Changed: +16, -12

5 Modified Paths:

/source/blender/editors/include/ED_view3d.h (+2, -1) (Diff)
/source/blender/editors/metaball/mball_edit.c (+1, -1) (Diff)
/source/blender/editors/space_view3d/view3d_select.c (+6, -6) (Diff)
/source/blender/editors/transform/transform_manipulator.c (+3, -3) (Diff)
/source/blender/gpu/intern/gpu_select.c (+4, -1) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021