Blender Git Commit Log

Git Commits -> Revision 2a8b987

Revision 2a8b987 by Bastien Montagne (master)
January 11, 2021, 16:59 (GMT)
Fix T83422: Dimensions incorrect after undoing if it has modified geometry.

Root of the issue is that `BKE_object_eval_boundbox` (that ports back
evaluated bbox to orig object during active depsgraph evaluation) is
only called when object's geometry actually is evaluated.

However, with new undo, often Object itself can be changed by undo,
without requiring its geometry to be re-evaluated, which was leading to
the evaluated bbox not being copied back into orig object anymore.

Fixing that by moving bbox copying-to-orig code into
`BKE_object_sync_to_original` instead, which is always executed when
object is evaluated (as hinted by the comment above
`BKE_object_eval_boundbox` actually).

Also allows to cleanup code for armature eval, apparently.

Maniphest Tasks: T83422

Differential Revision: https://developer.blender.org/D9789

Commit Details:

Full Hash: 2a8b987e9e4dacd788ce955966d28c04ed91caf3
Parent Commit: e44e0e4
Lines Changed: +8, -29

3 Modified Paths:

/source/blender/blenkernel/BKE_object.h (+0, -1) (Diff)
/source/blender/blenkernel/intern/armature_update.c (+0, -14) (Diff)
/source/blender/blenkernel/intern/object_update.c (+8, -14) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021