Blender Git Commit Log

Git Commits -> Revision 1570810

Revision 1570810 by Bastien Montagne (master)
June 23, 2021, 14:16 (GMT)
Fix (studio reported) crash on Undo in some cases.

Would crash when adding or removing a collection directly to the master
collection of a scene.

Consequence of change to handle depsgraph-controlled evaluation of some
IDs (like excluded collections which do not get evaluated and do not get
a COW anymore). See rBcf4258673755 and D10907.

Note that this mostly demonstrates once again how weak and flacky our
handling of embedded IDs still remains, with some part of the code
handling them as independent IDs, some as fully local/private data, some
as a mix of both... and lots and lots of custom handling code and corner
cases that are a bottomless pit of issues.

Also quiet incredible that this was not reported already, luckily this
original change did not make it to 2.93 release.

Commit Details:

Full Hash: 157081069d3bb758f4ac442780111e76bd9247f2
Parent Commit: befb9d9
Lines Changed: +16, -0

1 Modified Path:

/source/blender/depsgraph/intern/builder/deg_builder_nodes.cc (+16, -0) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021