Blender Git Loki
Git Commits -> Revision b9e5456
Revision b9e5456 by Julian Eisel (master) March 5, 2021, 16:46 (GMT) |
Cleanup: Add & use enum value for ID Outliner element type Code to check if the Outliner tree-element type was the general ID one would always check against "0" (explicity or even implicitly). For somebody unfamiliar with the code this is very confusing. Instead the value should be given a name, e.g. through an enum. Adds `TSE_SOME_ID` as the "default" ID tree-element type. Other types may still represent IDs, as I explained in a comment at the definition. There may also still be cases where the type is checked against "0". I noted in the comment that such cases should be cleaned up if found. |
Commit Details:
Full Hash: b9e54566e3b1a49d9757680da64d8e19c136c706
Parent Commit: ed84161
Lines Changed: +107, -85
17 Modified Paths:
/source/blender/blenkernel/intern/outliner_treehash.c (+2, -2) (Diff)
/source/blender/editors/space_outliner/outliner_collections.c (+5, -5) (Diff)
/source/blender/editors/space_outliner/outliner_context.c (+1, -1) (Diff)
/source/blender/editors/space_outliner/outliner_dragdrop.c (+4, -4) (Diff)
/source/blender/editors/space_outliner/outliner_draw.c (+18, -17) (Diff)
/source/blender/editors/space_outliner/outliner_edit.c (+4, -4) (Diff)
/source/blender/editors/space_outliner/outliner_select.c (+8, -8) (Diff)
/source/blender/editors/space_outliner/outliner_sync.c (+2, -2) (Diff)
/source/blender/editors/space_outliner/outliner_tools.c (+5, -4) (Diff)
/source/blender/editors/space_outliner/outliner_tree.c (+27, -24) (Diff)
/source/blender/editors/space_outliner/outliner_utils.c (+4, -4) (Diff)
/source/blender/editors/space_outliner/tree/tree_display_libraries.cc (+2, -2) (Diff)
/source/blender/editors/space_outliner/tree/tree_display_orphaned.cc (+2, -1) (Diff)
/source/blender/editors/space_outliner/tree/tree_display_scenes.cc (+2, -1) (Diff)
/source/blender/editors/space_outliner/tree/tree_display_view_layer.cc (+9, -5) (Diff)
/source/blender/editors/space_outliner/tree/tree_element_anim_data.cc (+2, -1) (Diff)
/source/blender/makesdna/DNA_outliner_types.h (+10, -0) (Diff)
/source/blender/editors/space_outliner/outliner_collections.c (+5, -5) (Diff)
/source/blender/editors/space_outliner/outliner_context.c (+1, -1) (Diff)
/source/blender/editors/space_outliner/outliner_dragdrop.c (+4, -4) (Diff)
/source/blender/editors/space_outliner/outliner_draw.c (+18, -17) (Diff)
/source/blender/editors/space_outliner/outliner_edit.c (+4, -4) (Diff)
/source/blender/editors/space_outliner/outliner_select.c (+8, -8) (Diff)
/source/blender/editors/space_outliner/outliner_sync.c (+2, -2) (Diff)
/source/blender/editors/space_outliner/outliner_tools.c (+5, -4) (Diff)
/source/blender/editors/space_outliner/outliner_tree.c (+27, -24) (Diff)
/source/blender/editors/space_outliner/outliner_utils.c (+4, -4) (Diff)
/source/blender/editors/space_outliner/tree/tree_display_libraries.cc (+2, -2) (Diff)
/source/blender/editors/space_outliner/tree/tree_display_orphaned.cc (+2, -1) (Diff)
/source/blender/editors/space_outliner/tree/tree_display_scenes.cc (+2, -1) (Diff)
/source/blender/editors/space_outliner/tree/tree_display_view_layer.cc (+9, -5) (Diff)
/source/blender/editors/space_outliner/tree/tree_element_anim_data.cc (+2, -1) (Diff)
/source/blender/makesdna/DNA_outliner_types.h (+10, -0) (Diff)
Master Commits
MiikaH:n Sivut a.k.a. MiikaHweb | 2003-2021