http://www.miikahweb.com/feed.php MiikaHweb - Blender Temp-sybren-anim-cleanup Branch http://www.miikahweb.com/ MiikaHweb - Blender Temp-sybren-anim-cleanup Branch fi Sat, 24 Jul 21 02:16:42 +0000 MiikaHweb RSS contact at miikahweb.com <![CDATA[[2f01899]: Cleanup: Animation, simplified fcurve_eval_between_keyframes...]]> http://www.miikahweb.com/en/blender/git-logs/commit/2f0189964ad5a4ae7cb819233c753df51a4b1508 2f01899
Branches : temp-sybren-anim-cleanup
Author : Sybren A. Stüvel (sybren)
----------------------------------------
Cleanup: Animation, simplified fcurve_eval_between_keyframes() code

The function now immediately returns the evaluated value, rather than
setting a variable's value and returning that at the end of the
function. As a result, `else`-clauses and `break` statements could be
removed, simplifying and unindenting the code.

Declarations of some variables that are only used in a specific part of
the function have been moved there to clarify and limit their scope.

No functional changes.

----------------------------------------
1 Path Changed]]>
Fri, 07 Feb 2020 16:51:18 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/2f0189964ad5a4ae7cb819233c753df51a4b1508Sybren A. Stüvel
<![CDATA[[559816a]: Animation: added unittests for FCurve evaluation]]> http://www.miikahweb.com/en/blender/git-logs/commit/559816a8cb41243eb5a11d122a201d19f636a880 559816a
Branches : temp-sybren-anim-cleanup
Author : Sybren A. Stüvel (sybren)
----------------------------------------
Animation: added unittests for FCurve evaluation

I want to clean up some of the FCurve evaluation functions by breaking
them up into smaller parts and simplifying some code paths. Before I do
that, however, I want to add some tests to ensure I don't mess up too
much.

----------------------------------------
3 Paths Changed]]>
Fri, 07 Feb 2020 16:51:18 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/559816a8cb41243eb5a11d122a201d19f636a880Sybren A. Stüvel
<![CDATA[[7766ba2]: Cleanup: Animation, split fcurve_eval_keyframes() into separate...]]> http://www.miikahweb.com/en/blender/git-logs/commit/7766ba2189c160686355a3eac2961f0f5253781f 7766ba2
Branches : temp-sybren-anim-cleanup
Author : Sybren A. Stüvel (sybren)
----------------------------------------
Cleanup: Animation, split fcurve_eval_keyframes() into separate functions

There are three main parts of the `fcurve_eval_keyframes()` function:

- before or on the first keyframe
- after or on the last keyframe
- between those points

These are now separated into separate functions. Apart from moving the
code, there are minimal code/cleanup changes. More cleanups to follow.

No functional changes.

----------------------------------------
1 Path Changed]]>
Fri, 07 Feb 2020 16:51:18 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/7766ba2189c160686355a3eac2961f0f5253781fSybren A. Stüvel
<![CDATA[[d690c76]: Cleanup: Animation, removed impossible-to-reach code]]> http://www.miikahweb.com/en/blender/git-logs/commit/d690c76e56cfc8858a7a31333716a87704c51508 d690c76
Branches : temp-sybren-anim-cleanup
Author : Sybren A. Stüvel (sybren)
----------------------------------------
Cleanup: Animation, removed impossible-to-reach code

While fixing T39207 @aligorith added a threshold to the binary search
function that's used to find the closest keyframe. Since that threshold
is larger than the threshold used in the now-removed code, the condition
in that code will evaluate to true anyway, and thus it can be removed.

----------------------------------------
1 Path Changed]]>
Fri, 07 Feb 2020 16:51:18 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/d690c76e56cfc8858a7a31333716a87704c51508Sybren A. Stüvel