http://www.miikahweb.com/feed.php MiikaHweb - Blender Commits By GuiltyGhost http://www.miikahweb.com/ MiikaHweb - Blender Commits By GuiltyGhost fi Wed, 20 Oct 21 08:01:37 +0000 MiikaHweb RSS contact at miikahweb.com <![CDATA[[9c4ecef] master: Fix T88375: Bone Size Small After V3D.View_All]]> http://www.miikahweb.com/en/blender/git-logs/commit/9c4ecef62f783156ab01904a6ead6b6eac23e7bf 9c4ecef
Branches : master
Author : Wayde Moss (GuiltyGhost)
----------------------------------------
Fix T88375: Bone Size Small After V3D.View_All

The wrong matrix function was used and overwrote the custom bone shape
scale instead of reading from it.

Reviewed By: sybren

Differential Revision: https://developer.blender.org/D11330

----------------------------------------
1 Path Changed]]>
Fri, 21 May 2021 17:24:55 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/9c4ecef62f783156ab01904a6ead6b6eac23e7bfWayde Moss
<![CDATA[[eb0a3c3] FixT87160_DSE_Channel_Selection: Fix T87160: DSE Keyframe Selection Now Selects Channels]]> http://www.miikahweb.com/en/blender/git-logs/commit/eb0a3c3b0c364b2e4b6e0f2e8d0b78053eeb5cdc eb0a3c3
Branches : FixT87160_DSE_Channel_Selection
Author : Wayde Moss (GuiltyGhost)
----------------------------------------
Fix T87160: DSE Keyframe Selection Now Selects Channels

Select All/Box/Circle/Lasso/MouseClick of keyframes now add channels to selection if any keydata was added to the selection.

Changed box/region select to sync channel selection instead of only ever adding channel to selection. Seems more intuitive

make tmp comments obvious (prefixed //)

Differential Revision: https://developer.blender.org/D11317

----------------------------------------
1 Path Changed]]>
Wed, 19 May 2021 23:19:00 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/eb0a3c3b0c364b2e4b6e0f2e8d0b78053eeb5cdcWayde Moss
<![CDATA[[8694b42] FixT87160_DSE_Channel_Selection: Fix T87160: DSE Keyframe Selection Now Selects Channels]]> http://www.miikahweb.com/en/blender/git-logs/commit/8694b428c78edc3e2baaeb8b00420acd0d8681b8 8694b42
Branches : FixT87160_DSE_Channel_Selection
Author : Wayde Moss (GuiltyGhost)
----------------------------------------
Fix T87160: DSE Keyframe Selection Now Selects Channels

Select All/Box/Circle/Lasso/MouseClick of keyframes now add channels to selection if any keydata was added to the selection.

----------------------------------------
7 Paths Changed]]>
Wed, 19 May 2021 23:14:10 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/8694b428c78edc3e2baaeb8b00420acd0d8681b8Wayde Moss
<![CDATA[[cbeeca8] master: NLA: Extract ..get_inverted_upper_snapshot()]]> http://www.miikahweb.com/en/blender/git-logs/commit/cbeeca8167f840798a0977906be911a09e7a63dd cbeeca8
Branches : master
Author : Wayde Moss (GuiltyGhost)
----------------------------------------
NLA: Extract ..get_inverted_upper_snapshot()

Extracts `nlasnapshot_blend_get_inverted_upper_snapshot()` from
`BKE_animsys_nla_remap_keyframe_values()`

This introduces a new struct member:
`NlaEvalChannelSnapshot->remap_domain` and marks which values of
`blended_snapshot` are processed for remapping/used-for-inverting.
Effectively, it marks which values have successfully been remapped and
can be further used for remapping.

`nlasnapshot_blend_get_inverted_upper_snapshot()`:
output snapshot `r_upper_snapshot` has each channel's `remap_domain`
written to which effectively marks the successfully remapped values.
The only reason a value is not in the remap domain is if inversion
failed or it wasn't marked to be remapped.

`..get_inverted_upper_snapshot()` has a variant `nlasnapshot_blend()`
from {D10220}, but this patch doesn't depend on it at all. A third
variant will later be added `..get_inverted_lower_snapshot()`.
Altogether, these three functions allow solving for any of
(lower_snapshot, upper_snapshot, blended_snapshot) given the other two.
The function `..get_inverted_lower_snapshot()` will also similarly
process the remap domain of the blended and lower snapshot.

added assertions within `nlasnapshot_blend()` and
`..get_inverted_upper_snapshot()` to future proof branches dealing with
blendmode and mixmodes. (suggested by sybren)

No user functional changes

Reviewed By: sybren

Differential Revision: https://developer.blender.org/D10222

----------------------------------------
2 Paths Changed]]>
Wed, 12 May 2021 02:00:07 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/cbeeca8167f840798a0977906be911a09e7a63ddWayde Moss
<![CDATA[[dcd7dac] master: Graph Editor: FCurve Show Extrapolation Toggle]]> http://www.miikahweb.com/en/blender/git-logs/commit/dcd7dacc4fd8d72f3388268959b1324f7aae95e4 dcd7dac
Branches : master
Author : Wayde Moss (GuiltyGhost)
----------------------------------------
Graph Editor: FCurve Show Extrapolation Toggle

Adds toggle to graph editor (View->Show Extrapolation). When disabled,
then fcurves only draw over the keyframe range. For baked fcurves and
ghost fcurves, the range is all sampled points.

It is intended for frequent use so anybody could assign hotkey or add
to quick favorites that's why GE-View is the best place for it.

Show Extrapolation is the default.

Reviewed By: sybren, Stan1, looch

Differential Revision: http://developer.blender.org/D10442

----------------------------------------
4 Paths Changed]]>
Tue, 09 Mar 2021 20:09:09 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/dcd7dacc4fd8d72f3388268959b1324f7aae95e4Wayde Moss
<![CDATA[[6a3ae75] temp_D10504-2_nla_keyframe_remap_upper_strips: manual patch]]> http://www.miikahweb.com/en/blender/git-logs/commit/6a3ae75656a4247d39050c54ce5a6edf4f67d29f 6a3ae75
Branches : temp_D10504-2_nla_keyframe_remap_upper_strips
Author : Wayde Moss (GuiltyGhost)
----------------------------------------
manual patch

----------------------------------------
9 Paths Changed]]>
Tue, 09 Mar 2021 00:44:36 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/6a3ae75656a4247d39050c54ce5a6edf4f67d29fWayde Moss
<![CDATA[[2d0117f] temp_D10504_nla_keyframe_remap_upper_strips: NLA: Keyframe Remap Through Upper Strips]]> http://www.miikahweb.com/en/blender/git-logs/commit/2d0117ff45945e286e833dd2332efedb999da86d 2d0117f
Branches : temp_D10504_nla_keyframe_remap_upper_strips
Author : Wayde Moss (GuiltyGhost)
----------------------------------------
NLA: Keyframe Remap Through Upper Strips

Differential Revision: https://developer.blender.org/D10504

----------------------------------------
4 Paths Changed]]>
Mon, 22 Feb 2021 20:33:02 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/2d0117ff45945e286e833dd2332efedb999da86dWayde Moss
<![CDATA[[0cc9127] temp_D10504_nla_keyframe_remap_upper_strips: include D9925: NLA Tweak Mode: Evaluate Upper Stack]]> http://www.miikahweb.com/en/blender/git-logs/commit/0cc91272e94782f4cda033d65fbac1656de301c2 0cc9127
Branches : temp_D10504_nla_keyframe_remap_upper_strips
Author : Wayde Moss (GuiltyGhost)
----------------------------------------
include D9925: NLA Tweak Mode: Evaluate Upper Stack

----------------------------------------
6 Paths Changed]]>
Fri, 19 Feb 2021 18:16:26 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/0cc91272e94782f4cda033d65fbac1656de301c2Wayde Moss
<![CDATA[[3a203f4] temp_D10504_nla_keyframe_remap_upper_strips: - Overlooked remap_domain writing, now sets remap_domain on...]]> http://www.miikahweb.com/en/blender/git-logs/commit/3a203f420f3f47a180295f8a2a3dffaf436c3c2d 3a203f4
Branches : temp_D10504_nla_keyframe_remap_upper_strips
Author : Wayde Moss (GuiltyGhost)
----------------------------------------
- Overlooked remap_domain writing, now sets remap_domain on output even when succeeds. This didn't have any effect for user as the input blended_snapshot and output upper_snapshot were always the same.

----------------------------------------
1 Path Changed]]>
Wed, 17 Feb 2021 21:16:06 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/3a203f420f3f47a180295f8a2a3dffaf436c3c2dWayde Moss
<![CDATA[[c312813] temp_D10504_nla_keyframe_remap_upper_strips: - rebase and minor cleanup]]> http://www.miikahweb.com/en/blender/git-logs/commit/c31281310ccda1536a6837433d4c0758ed93e1d6 c312813
Branches : temp_D10504_nla_keyframe_remap_upper_strips
Author : Wayde Moss (GuiltyGhost)
----------------------------------------
- rebase and minor cleanup

----------------------------------------
1 Path Changed]]>
Wed, 17 Feb 2021 06:20:22 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/c31281310ccda1536a6837433d4c0758ed93e1d6Wayde Moss
<![CDATA[[095a1db] temp_D10504_nla_keyframe_remap_upper_strips: minor cleanup]]> http://www.miikahweb.com/en/blender/git-logs/commit/095a1db2062ac9f1d87826f8f68daa85716433f8 095a1db
Branches : temp_D10504_nla_keyframe_remap_upper_strips
Author : Wayde Moss (GuiltyGhost)
----------------------------------------
minor cleanup

----------------------------------------
2 Paths Changed]]>
Wed, 17 Feb 2021 06:12:33 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/095a1db2062ac9f1d87826f8f68daa85716433f8Wayde Moss
<![CDATA[[7f74c8c] temp_D10504_nla_keyframe_remap_upper_strips: NLA: Extract nlasnapshot_blend_get_inverted_upper_snapshot()]]> http://www.miikahweb.com/en/blender/git-logs/commit/7f74c8c479ecaa59d9ea6573373c17c3035e72a5 7f74c8c
Branches : temp_D10504_nla_keyframe_remap_upper_strips
Author : Wayde Moss (GuiltyGhost)
----------------------------------------
NLA: Extract nlasnapshot_blend_get_inverted_upper_snapshot()

Extracts //nlasnapshot_blend_get_inverted_upper_snapshot()// from //BKE_animsys_nla_remap_keyframe_values()//

- This introduces a new struct member: `NlaEvalChannelSnapshot->invertible` which marks values which have successfully been inverted and can be further used for solving.
- //nlasnapshot_mark_all_invertible()// is unused in this patch but seemed generally useful when using snapshots for remapping. {D8867} would be able to make use of it.
- //nlasnapshot_blend_get_inverted_upper_snapshot()// has a variant //nlasnapshot_blend()// from {D10220}, but this patch doesn't depend on it at all. A third variant will later be added //nlasnapshot_blend_get_inverted_lower_snapshot()//. Altogether, these three functions allow solving for any of (lower_snapshot, upper_snapshot, blended_snapshot) given the other two.

No user functional changes

Differential Revision: https://developer.blender.org/D10222

----------------------------------------
2 Paths Changed]]>
Wed, 17 Feb 2021 06:12:33 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/7f74c8c479ecaa59d9ea6573373c17c3035e72a5Wayde Moss
<![CDATA[[9cfce14] temp_T76472_graph_editor_fcurve_extrapolation: - ghost fcurve drawing uses Show Extrapolation setting]]> http://www.miikahweb.com/en/blender/git-logs/commit/9cfce143bcc83f359b2837c5d4830c467ed6ef56 9cfce14
Branches : temp_T76472_graph_editor_fcurve_extrapolation
Author : Wayde Moss (GuiltyGhost)
----------------------------------------
- ghost fcurve drawing uses Show Extrapolation setting

----------------------------------------
1 Path Changed]]>
Thu, 18 Feb 2021 15:49:11 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/9cfce143bcc83f359b2837c5d4830c467ed6ef56Wayde Moss
<![CDATA[[17dddc9] master: Fix: NLA Blend Domain Enable All Typo]]> http://www.miikahweb.com/en/blender/git-logs/commit/17dddc94171497c616eea8bcf47215ae118dd162 17dddc9
Branches : master
Author : Wayde Moss (GuiltyGhost)
----------------------------------------
Fix: NLA Blend Domain Enable All Typo

Introduced by my recent commit: rBc48360c2559a

Accidentally used 4 instead of `necs->length`.

----------------------------------------
1 Path Changed]]>
Wed, 17 Feb 2021 06:07:08 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/17dddc94171497c616eea8bcf47215ae118dd162Wayde Moss
<![CDATA[[c48360c] master: Fix: NLA Blends Non-Animated Upper Channel Values]]> http://www.miikahweb.com/en/blender/git-logs/commit/c48360c2559acbe1cb8014ca0e81152f2febf199 c48360c
Branches : master
Author : Wayde Moss (GuiltyGhost)
----------------------------------------
Fix: NLA Blends Non-Animated Upper Channel Values

Issue introduced by my commit: rB40b7929cc040

**User-level Problem**:
The issue resulted in a full-replace upper strip with only a Z location
channel full-replacing the XY location channels of the lower stack.
replaced to default. The expected behavior is that only the Z location
channel is affected.

**Technical-level Problem**:
Before the problematic commit, fcurves were blended as they were read.
So only existing animated channels would blend. My recent commit
changed the process to read all fcurve values into an isolated
upper_snapshot then blend with the lower stack. There is no data stored
to know whether the upper snapshot channel values were sampled from
fcurves or were default values. Only those sampled from fcurves should
be blended.

**Solution**:
Added a `blend_domain` bitmask member to NlaEvalChannelSnapshot.
The blending function only blends values within the `blend_domain`.
Sampled fcurve values are now marked as within the `blend_domain`.
We also now always copy the lower snapshot to the result snapshot which
only matters when they aren't the same. Currently, it's always the same
so the change is more for future unseen cases.

Reviewed By: sybren, #animation_rigging

Differential Revision: https://developer.blender.org/D10339

----------------------------------------
2 Paths Changed]]>
Wed, 17 Feb 2021 05:21:07 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/c48360c2559acbe1cb8014ca0e81152f2febf199Wayde Moss
<![CDATA[[2a3254a] temp_T76472_graph_editor_fcurve_extrapolation: Graph Editor: FCurve Extrapolation Visibility T76472]]> http://www.miikahweb.com/en/blender/git-logs/commit/2a3254a4b1089b52b2fe74324b4a895cec0dedd8 2a3254a
Branches : temp_T76472_graph_editor_fcurve_extrapolation
Author : Wayde Moss (GuiltyGhost)
----------------------------------------
Graph Editor: FCurve Extrapolation Visibility T76472

Adds toggle to graph editor (View->Show Extrapolation). When disabled, then fcurves only draw over the keyframe range. For baked fcurves, the range is all sampled points. For ghost fcurves, extraplation is always drawn since the sampled points may include extrapolated points of the original fcurve.

Show Extrapolation is the default.
___

**Technical Notes**:
- `draw_fcurve_curve()`: There are now explicit checks for floating point poor accuracy cases. Without them, then there would be visual flickering when no extrapolation is drawn and there is a discontinuity at the end (due to cyclic modifier). This removes the need for the `+samplefreq` in `etime = v2d->curxmax + samplefreq`. It also removes the need to do so on `fcu_start/fcu_end`.
- `draw_fcurve_curve()`: Besides the previous note, the only other meaningful change is the `if(!draw_extrapolation)` branch which just changes `stime/etime` to match the keyframe bounds instead.

Differential Revision: https://developer.blender.org/D10442

----------------------------------------
4 Paths Changed]]>
Wed, 17 Feb 2021 04:42:57 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/2a3254a4b1089b52b2fe74324b4a895cec0dedd8Wayde Moss
<![CDATA[[abfb9db] master: Fix: Disabled NLA Interferes with Action Eval]]> http://www.miikahweb.com/en/blender/git-logs/commit/abfb9dbf593d1f781d321e387701a8ac0c2fe423 abfb9db
Branches : master
Author : Wayde Moss (GuiltyGhost)
----------------------------------------
Fix: Disabled NLA Interferes with Action Eval

Introduced by my commit: rB09709a7e64ff

This bug effectively enabled the NLA when it should be disabled, when
all tracks muted or no strips exist. Specifically, the NLA Action Track
settings would be used (extrapolation, blendmode, influence).

----------------------------------------
1 Path Changed]]>
Fri, 05 Feb 2021 22:47:56 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/abfb9dbf593d1f781d321e387701a8ac0c2fe423Wayde Moss
<![CDATA[[10e23fd] master: NLA: Refactor Transition, Use Snapshot Blend Func]]> http://www.miikahweb.com/en/blender/git-logs/commit/10e23fd1046a0fd1f2e2f7cac7fc897cc0ea99be 10e23fd
Branches : master
Author : Wayde Moss (GuiltyGhost)
----------------------------------------
NLA: Refactor Transition, Use Snapshot Blend Func

The function `nlastrip_evaluate_transition()` has been slightly
modified to use `nlasnapshot_blend()` instead of it's own special
blending function `nlaeval_snapshot_mix_and_free()`.

No user functional changes

Reviewed By: sybren, #animation_rigging

Differential Revision: https://developer.blender.org/D10221

----------------------------------------
2 Paths Changed]]>
Fri, 05 Feb 2021 21:52:43 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/10e23fd1046a0fd1f2e2f7cac7fc897cc0ea99beWayde Moss
<![CDATA[[5bc9ddd] master: Fix T85380: NLA Evaluation Missing Null Check]]> http://www.miikahweb.com/en/blender/git-logs/commit/5bc9ddd98b3664bce2e0e7ebf92f1de62331e7b4 5bc9ddd
Branches : master
Author : Wayde Moss (GuiltyGhost)
----------------------------------------
Fix T85380: NLA Evaluation Missing Null Check

Introduced by commit: rB40b7929cc040

----------------------------------------
1 Path Changed]]>
Fri, 05 Feb 2021 19:19:38 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/5bc9ddd98b3664bce2e0e7ebf92f1de62331e7b4Wayde Moss
<![CDATA[[0352546] master: NLA: Fix nlasnapshot_blend() Misplaced Null Check]]> http://www.miikahweb.com/en/blender/git-logs/commit/0352546cdd3814770053f80771c3abf20a4bd60b 0352546
Branches : master
Author : Wayde Moss (GuiltyGhost)
----------------------------------------
NLA: Fix nlasnapshot_blend() Misplaced Null Check

From original commit: rB40b7929cc040

----------------------------------------
1 Path Changed]]>
Wed, 03 Feb 2021 22:35:21 +0000 http://www.miikahweb.com/en/blender/git-logs/commit/0352546cdd3814770053f80771c3abf20a4bd60bWayde Moss