Blender Git Statistics -> Developers -> zazizizou

Habib Gahbiche (zazizizou)

Total Commits : 9
Master Commits : 9
Branch Commits : 0
First Commit : August 31, 2018
Latest Commit : November 9, 2018

Commits by Month

DateNumber of Commits
November, 20184
October, 20182
September, 20180
August, 20183

Favourite Files

FilenameTotal Edits
editcurve_select.c4
editmesh_tools.c3
editmesh_select_similar.c2
mball.c1
ED_curve.h1
BKE_mball.h1
bmesh_query.c1
bmesh_query.h1
ED_select_utils.h1
bmesh_polygon.c1

File Changes

ActionTotalPer Commit
Modified192.1

Code Changes

ActionTotalPer Commit
Lines Added80289.1
Lines Removed48754.1

Latest commits Feed

Revision 0c1934f by Habib Gahbiche / Dalai Felinto (master)
November 9, 2018, 19:19 (GMT)
Multi-Objects: MESH_OT_select_similar worldspace completion

This makes the operator to work 100% with worldspace similarity:
* SIMFACE_PERIMETER
* SIMFACE_AREA
* SIMEDGE_FACE_ANGLE

Note from revisor (Dalai Felinto):

I'm not sure we want to pass Object * to the bmesh api, though I
personally don't see why not. Either way I group the patches together so
we can more easily roll them back if needs be.

Maniphest Tasks: T56948
Differential Revision: D3908, D3899, D3896
Revision ab77f5b by Habib Gahbiche / Dalai Felinto (master)
November 9, 2018, 11:39 (GMT)
Improvements on CURVE_OT_select_similar: SIMCURHAND_DIRECTION

Consider rotation and scale when calculating direction in world space.

Reviewers: dfelinto
Maniphest Tasks: T56948

Differential Revision: https://developer.blender.org/D3911
Revision 5f8d369 by Habib Gahbiche / Dalai Felinto (master)
November 7, 2018, 02:15 (GMT)
Multi-Objects: MBALL_OT_select_similar

Compared to previous implementation, the following has been changed:
* Threshold: is now an absolute value. This allows a comparison with e.g. radii
that are much larger than selected radius. This is also consistent with
`CURVE_OT_select_similar`

* Radius in world space is the average of the radius scaled in x, y and z
directions
* Since MetaBalls are symmetrical, rotation is only considered from 0 to ?/2.
So for example rotations of 90° and -90° are considered equal.
This is also consistent with the way `CURVE_OT_select_similar` works.

Fix/changes from committer (Dalai Felinto):
* Drawing not updating after changes. (see original patch for details).

Reviewers: dfelinto
Differential Revision: https://developer.blender.org/D3895
Revision 4e99116 by Habib Gahbiche / Dalai Felinto (master)
November 7, 2018, 00:56 (GMT)
Multi-Objects: CURVE_OT_select_similar

Implemented the following methods:
* SIMCURHAND_TYPE
* SIMCURHAND_RADIUS
* SIMCURHAND_WEIGHT
* SIMCURHAND_DIRECTION

Limits:
* DIRECTION does not support surfaces, because `BKE_nurb_bpoint_calc_normal`
does not work with Nurbs of type `CU_CARDINAL`. This also didn't work prior
to this patch, so we wait until surfaces are properly supported in EditMode.

* Also DIRECTION should take scaling into consideration. We need our own
versions of BKE_nurb_bpoint_calc_normal/bezt.

* Threshold default is too large. Not sure if it's better to change the default
or scale the threshold in code.

Differential Revision: https://developer.blender.org/D3846

Changes from committer (Dalai Felinto):
* Moved nurb_bpoint_direction_worldspace_get/bezt to functions.
* Comments hinting at the mode (direction) that require scaling to be
taken into account - to be addressed by patch creator in a future
patch.
Revision 9d9d44d by Habib Gahbiche / Dalai Felinto (master)
October 30, 2018, 19:22 (GMT)
Multi-Objects: CURVE_OT_de_select_first

Reviewers: dfelinto
https://developer.blender.org/D3839
Revision df613a5 by Habib Gahbiche / Dalai Felinto (master)
October 30, 2018, 19:22 (GMT)
Multi-Objects: CURVE_OT_de_select_last

Reviewers: dfelinto
https://developer.blender.org/D3841
Revision 6ae09df by Habib Gahbiche / Dalai Felinto (master)
August 31, 2018, 18:20 (GMT)
Multi-Object-Mode: MESH_OT_blend_from_shape

"Blend from Shape" lists keys from active object and applies to all selected
objects that have keys with a matching name.

Changes from reviewer (Dalai Felinto):
* Code Style.
* Move Object **objects after sanity check to prevent leak when
returning OPERATOR_CANCELLED.
* Skip objects that have no selected vertex.
* Fixed existent comments code-style: Since we are changing the indentation of
these lines, may as well correct this as well.

Differential Revision: https://developer.blender.org/D3656
Revision 3a43528 by Habib Gahbiche / Dalai Felinto (master)
August 31, 2018, 17:20 (GMT)
Multi-Objects: MESH_OT_shape_propagate_to_all

Pressing "Propagate to Shapes" now propagates the current shapes to the selected
object's respective keys, if at least one selected object has shape keys.

Discussion here:
https://devtalk.blender.org/t/behaviour-of-shape-keys-in-multi-object-mode/1956/4

Changes from reviewer (Dalai Felinto):
* Code style
* Error message
* Remove dead code

Reviewers: dfelinto
Differential Revision: https://developer.blender.org/D3651
Revision 1f30232 by Habib Gahbiche / Dalai Felinto (master)
August 31, 2018, 14:45 (GMT)
Multi-Object-Editing: MESH_OT_vertices_smooth_laplacian

Since D3284 was inactive for a long time, I figured I could finish this.

This revision also gives warning when there are no selected faces or when
selected faces are invalid.

Changes from reviewer (Dalai Felinto) :
* Code style
* Fix checking for ngons (BM_ITER_MESH is a for loop, you need to break from it
before continuing the object iteration loop).

Differential Revision: https://developer.blender.org/D3659

MiikaHweb - Blender Git Statistics v1.06
By: Miika HämäläinenLast update: Nov-07-2014 14:18 MiikaHweb | 2003-2019