Blender Git Statistics -> Developers -> qmax

Maxim Vasiliev (qmax)

Total Commits : 2
Master Commits : 2
Branch Commits : 0
First Commit : January 5, 2020
Latest Commit : April 6, 2020

Commits by Month

DateNumber of Commits
April, 20201
March, 20200
February, 20200
January, 20201

Favourite Files

FilenameTotal Edits
node.c1
node_group.c1

File Changes

ActionTotalPer Commit
Modified21.0

Code Changes

ActionTotalPer Commit
Lines Added63.0
Lines Removed63.0

Latest commits Feed

Revision c544df9 by Maxim Vasiliev / Bastien Montagne (master)
April 6, 2020, 14:27 (GMT)
Fix user counting when ungrouping a node group.

Existing code for ungrouping did not correctly handle user counters:

- counter for the group was not decremented
- counters for containing nodes were not incremented

The latter resulted in losing some nodes after orphan cleaning or several save/reload cycles.

The bug did not have destructive consequences until recently,
because it was compensated by another bug (fixed in rBe993667a46c2).

Maniphest Tasks: T74665, T74682

Differential Revision: https://developer.blender.org/D7332
Revision e993667 by Maxim Vasiliev / Bastien Montagne (master)
January 5, 2020, 17:27 (GMT)
Fix (unreported) critical mistake in Node copying code.

Nice reversed-logic mistake in rB693721cc7e7d.

How this could remain unnoticed for almost one year is fairly
mysterious, this should have basically broke all node tree copying,
would expect such bug to get reported within days, weeks at most...
Probably because that function is not that much used in current code.

Nice reminder also that those bloody nodetrees still need a lot of
cleanup/refactor/simplification when it comes to ID management code.

Reported/fixed as part of D6484, but this really needs its own commit.

MiikaHweb - Blender Git Statistics v1.06
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021