Blender Git Commit Log

Git Commits -> Revision f49d438

Revision f49d438 by Sebastian Parborg (master)
August 25, 2021, 15:30 (GMT)
Cleanup and remove SEQ_ALL_BEGIN macro

We now use a for_each function with callback to iterate through all sequences in the scene.

This has the benefit that we now only loop over the sequences in the scene once.
Before we would loop over them twice and allocate memory to store temporary data.

The allocation of temporary data lead to unintentional memory leaks if the code used returns to exit out of the iteration loop.
The new for_each callback method doesn't allocate any temporary data and only iterates though all sequences once.

Reviewed By: Richard Antalik, Bastien Montagne

Differential Revision: https://developer.blender.org/D12278

Commit Details:

Full Hash: f49d438ced7c5874dbf43976d9901a462176f541
Parent Commit: 796035a
Lines Changed: +918, -738

28 Modified Paths:

/source/blender/blenkernel/BKE_scene.h (+0, -8) (Diff)
/source/blender/blenkernel/intern/bpath.c (+42, -32) (Diff)
/source/blender/blenkernel/intern/ipo.c (+54, -46) (Diff)
/source/blender/blenkernel/intern/scene.c (+41, -298) (Diff)
/source/blender/blenloader/intern/readfile.c (+3, -3) (Diff)
/source/blender/blenloader/intern/versioning_250.c (+47, -33) (Diff)
/source/blender/blenloader/intern/versioning_260.c (+52, -44) (Diff)
/source/blender/blenloader/intern/versioning_270.c (+43, -36) (Diff)
/source/blender/blenloader/intern/versioning_280.c (+11, -10) (Diff)
/source/blender/blenloader/intern/versioning_legacy.c (+19, -13) (Diff)
/source/blender/depsgraph/intern/builder/deg_builder_nodes.cc (+24, -20) (Diff)
/source/blender/depsgraph/intern/builder/deg_builder_relations.cc (+44, -30) (Diff)
/source/blender/depsgraph/intern/eval/deg_eval_runtime_backup_sequencer.cc (+29, -19) (Diff)
/source/blender/editors/sound/sound_ops.c (+4, -6) (Diff)
/source/blender/editors/space_sequencer/sequencer_edit.c (+19, -7) (Diff)
/source/blender/imbuf/intern/colormanagement.c (+10, -6) (Diff)
/source/blender/makesrna/intern/rna_color.c (+26, -14) (Diff)
/source/blender/makesrna/intern/rna_sequencer.c (+20, -20) (Diff)
/source/blender/sequencer/intern/clipboard.c (+1, -1) (Diff)
/source/blender/sequencer/intern/iterator.c (+46, -11) (Diff)
/source/blender/sequencer/intern/proxy.c (+1, -1) (Diff)
/source/blender/sequencer/intern/sequencer.c (+329, -8) (Diff)
/source/blender/sequencer/intern/sequencer.h (+4, -1) (Diff)
/source/blender/sequencer/intern/strip_relations.c (+19, -16) (Diff)
/source/blender/sequencer/intern/utils.c (+3, -31) (Diff)
/source/blender/sequencer/SEQ_iterator.h (+7, -18) (Diff)
/source/blender/sequencer/SEQ_sequencer.h (+20, -0) (Diff)
/source/blender/sequencer/SEQ_utils.h (+0, -6) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021