Blender Git Commit Log

Git Commits -> Revision d525514

Revision d525514 by Julian Eisel (master)
January 16, 2020, 15:13 (GMT)
Fix wrong usages of region align enumerations

`ARegion.alignment` unfortunately is a mixture of value and bitflag
enumerations. When checking for left/right/top/bottom region alignment,
the flags have to be masked out usually.
Most of the fixed cases here probably didn't cause issues in practice,
but could in fact break at any point when surrounding logic changes.

In fact the assert in #region_visible_rect_calc() failed in an older
file from https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=949035. This
fixes it.

Commit Details:

Full Hash: d52551401e185a3e1092fb07edebd07d552e04e2
Parent Commit: 5b8c230
Lines Changed: +56, -40

12 Modified Paths:

/source/blender/editors/interface/interface_align.c (+1, -1) (Diff)
/source/blender/editors/interface/interface_handlers.c (+4, -2) (Diff)
/source/blender/editors/interface/interface_layout.c (+13, -11) (Diff)
/source/blender/editors/interface/interface_panel.c (+3, -3) (Diff)
/source/blender/editors/interface/interface_region_menu_popup.c (+2, -2) (Diff)
/source/blender/editors/interface/interface_region_popover.c (+2, -2) (Diff)
/source/blender/editors/screen/area.c (+9, -4) (Diff)
/source/blender/editors/screen/area_query.c (+8, -4) (Diff)
/source/blender/editors/screen/screen_ops.c (+9, -6) (Diff)
/source/blender/editors/space_statusbar/space_statusbar.c (+1, -1) (Diff)
/source/blender/editors/space_topbar/space_topbar.c (+2, -2) (Diff)
/source/blender/windowmanager/intern/wm_draw.c (+2, -2) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021