Blender Git Commit Log

Git Commits -> Revision 0dd9a4a

Revision 0dd9a4a by Sergey Sharybin (master)
March 5, 2021, 14:05 (GMT)
Cleanup: Libmv, clang-format

Is based on Google style which was used in the Libmv project before,
but is now consistently applied for the sources of the library itself
and to C-API. With some time C-API will likely be removed, and it
makes it easier to make it follow Libmv style, hence the diversion
from Blender's style.

There are quite some exceptions (clang-format off) in the code around
Eigen matrix initialization. It is rather annoying, and there could be
some neat way to make initialization readable without such exception.

Could be some places where loss of readability in matrix initialization
got lost as the change is quite big. If this has happened it is easier
to address readability once actually working on the code.

This change allowed to spot some missing header guards, so that's nice.

Doing it in bundled version, as the upstream library needs to have some
of the recent development ported over from bundle to upstream.

There should be no functional changes.

Commit Details:

Full Hash: 0dd9a4a576452007da9d3f02a03499e50a8ddfae
Parent Commit: e0442a9
Lines Changed: +4928, -4504

151 Modified Paths:

/intern/libmv/.clang-format (+34, -2) (Diff)
/intern/libmv/intern/autotrack.cc (+15, -20) (Diff)
/intern/libmv/intern/autotrack.h (+5, -5) (Diff)
/intern/libmv/intern/camera_intrinsics.cc (+198, -238) (Diff)
/intern/libmv/intern/camera_intrinsics.h (+6, -6) (Diff)
/intern/libmv/intern/detector.cc (+8, -8) (Diff)
/intern/libmv/intern/detector.h (+1, -1) (Diff)
/intern/libmv/intern/frame_accessor.cc (+42, -59) (Diff)
/intern/libmv/intern/frame_accessor.h (+10, -9) (Diff)
/intern/libmv/intern/homography.cc (+2, -4) (Diff)
/intern/libmv/intern/image.cc (+33, -31) (Diff)
/intern/libmv/intern/image.h (+15, -15) (Diff)
/intern/libmv/intern/reconstruction.cc (+106, -123) (Diff)
/intern/libmv/intern/reconstruction.h (+21, -25) (Diff)
/intern/libmv/intern/stub.cc (+103, -111) (Diff)
/intern/libmv/intern/tracks.cc (+3, -3) (Diff)
/intern/libmv/intern/tracksN.cc (+18, -21) (Diff)
/intern/libmv/intern/tracksN.h (+4, -6) (Diff)
/intern/libmv/intern/track_region.cc (+19, -24) (Diff)
/intern/libmv/intern/track_region.h (+4, -4) (Diff)
/intern/libmv/intern/utildefines.h (+21, -15) (Diff)
/intern/libmv/libmv/autotrack/autotrack.cc (+31, -37) (Diff)
/intern/libmv/libmv/autotrack/autotrack.h (+28, -30) (Diff)
/intern/libmv/libmv/autotrack/frame_accessor.h (+3, -6) (Diff)
/intern/libmv/libmv/autotrack/marker.h (+13, -26) (Diff)
/intern/libmv/libmv/autotrack/model.h (+2, -7) (Diff)
/intern/libmv/libmv/autotrack/predict_tracks.cc (+38, -22) (Diff)
/intern/libmv/libmv/autotrack/predict_tracks_test.cc (+19, -25) (Diff)
/intern/libmv/libmv/autotrack/quad.h (+3, -3) (Diff)
/intern/libmv/libmv/autotrack/reconstruction.h (+6, -6) (Diff)
/intern/libmv/libmv/autotrack/region.h (+1, -1) (Diff)
/intern/libmv/libmv/autotrack/tracks.cc (+20, -23) (Diff)
/intern/libmv/libmv/autotrack/tracks.h (+7, -5) (Diff)
/intern/libmv/libmv/autotrack/tracks_test.cc (+1, -1) (Diff)
/intern/libmv/libmv/base/aligned_malloc.cc (+3, -3) (Diff)
/intern/libmv/libmv/base/aligned_malloc.h (+2, -2) (Diff)
/intern/libmv/libmv/base/id_generator.h (+1, -0) (Diff)
/intern/libmv/libmv/base/map.h (+1, -1) (Diff)
/intern/libmv/libmv/base/scoped_ptr.h (+20, -18) (Diff)
/intern/libmv/libmv/base/scoped_ptr_test.cc (+4, -4) (Diff)
/intern/libmv/libmv/base/vector_test.cc (+4, -4) (Diff)
/intern/libmv/libmv/base/vector_utils.h (+2, -3) (Diff)
/intern/libmv/libmv/image/array_nd.cc (+13, -14) (Diff)
/intern/libmv/libmv/image/array_nd.h (+77, -111) (Diff)
/intern/libmv/libmv/image/array_nd_test.cc (+5, -5) (Diff)
/intern/libmv/libmv/image/convolve.cc (+87, -83) (Diff)
/intern/libmv/libmv/image/convolve.h (+31, -31) (Diff)
/intern/libmv/libmv/image/convolve_test.cc (+6, -6) (Diff)
/intern/libmv/libmv/image/correlation.h (+5, -6) (Diff)
/intern/libmv/libmv/image/image.h (+37, -56) (Diff)
/intern/libmv/libmv/image/image_converter.h (+11, -10) (Diff)
/intern/libmv/libmv/image/image_drawing.h (+59, -53) (Diff)
/intern/libmv/libmv/image/image_test.cc (+3, -3) (Diff)
/intern/libmv/libmv/image/sample.h (+20, -20) (Diff)
/intern/libmv/libmv/image/sample_test.cc (+7, -7) (Diff)
/intern/libmv/libmv/image/tuple.h (+18, -14) (Diff)
/intern/libmv/libmv/multiview/conditioning.cc (+15, -13) (Diff)
/intern/libmv/libmv/multiview/conditioning.h (+11, -13) (Diff)
/intern/libmv/libmv/multiview/euclidean_resection.cc (+103, -95) (Diff)
/intern/libmv/libmv/multiview/euclidean_resection.h (+24, -23) (Diff)
/intern/libmv/libmv/multiview/euclidean_resection_test.cc (+44, -30) (Diff)
/intern/libmv/libmv/multiview/fundamental.cc (+112, -115) (Diff)
/intern/libmv/libmv/multiview/fundamental.h (+55, -60) (Diff)
/intern/libmv/libmv/multiview/fundamental_test.cc (+6, -2) (Diff)
/intern/libmv/libmv/multiview/homography.cc (+123, -126) (Diff)
/intern/libmv/libmv/multiview/homography.h (+17, -17) (Diff)
/intern/libmv/libmv/multiview/homography_error.h (+58, -62) (Diff)
/intern/libmv/libmv/multiview/homography_parameterization.h (+22, -14) (Diff)
/intern/libmv/libmv/multiview/homography_test.cc (+35, -5) (Diff)
/intern/libmv/libmv/multiview/nviewtriangulation.h (+16, -16) (Diff)
/intern/libmv/libmv/multiview/nviewtriangulation_test.cc (+2, -2) (Diff)
/intern/libmv/libmv/multiview/panography.cc (+26, -21) (Diff)
/intern/libmv/libmv/multiview/panography.h (+7, -5) (Diff)
/intern/libmv/libmv/multiview/panography_kernel.cc (+2, -2) (Diff)
/intern/libmv/libmv/multiview/panography_kernel.h (+9, -9) (Diff)
/intern/libmv/libmv/multiview/panography_test.cc (+18, -8) (Diff)
/intern/libmv/libmv/multiview/projection.cc (+36, -22) (Diff)
/intern/libmv/libmv/multiview/projection.h (+62, -62) (Diff)
/intern/libmv/libmv/multiview/projection_test.cc (+14, -4) (Diff)
/intern/libmv/libmv/multiview/resection.h (+9, -9) (Diff)
/intern/libmv/libmv/multiview/resection_test.cc (+4, -4) (Diff)
/intern/libmv/libmv/multiview/test_data_sets.cc (+20, -13) (Diff)
/intern/libmv/libmv/multiview/test_data_sets.h (+23, -19) (Diff)
/intern/libmv/libmv/multiview/triangulation.cc (+11, -7) (Diff)
/intern/libmv/libmv/multiview/triangulation.h (+10, -6) (Diff)
/intern/libmv/libmv/multiview/triangulation_test.cc (+1, -1) (Diff)
/intern/libmv/libmv/multiview/two_view_kernel.h (+14, -17) (Diff)
/intern/libmv/libmv/numeric/dogleg.h (+65, -54) (Diff)
/intern/libmv/libmv/numeric/dogleg_test.cc (+16, -15) (Diff)
/intern/libmv/libmv/numeric/function_derivative.h (+9, -8) (Diff)
/intern/libmv/libmv/numeric/function_derivative_test.cc (+9, -9) (Diff)
/intern/libmv/libmv/numeric/levenberg_marquardt.h (+38, -32) (Diff)
/intern/libmv/libmv/numeric/levenberg_marquardt_test.cc (+4, -6) (Diff)
/intern/libmv/libmv/numeric/numeric.cc (+20, -16) (Diff)
/intern/libmv/libmv/numeric/numeric.h (+192, -201) (Diff)
/intern/libmv/libmv/numeric/numeric_test.cc (+63, -29) (Diff)
/intern/libmv/libmv/numeric/poly.h (+13, -16) (Diff)
/intern/libmv/libmv/numeric/poly_test.cc (+18, -8) (Diff)
/intern/libmv/libmv/simple_pipeline/bundle.cc (+240, -218) (Diff)
/intern/libmv/libmv/simple_pipeline/bundle.h (+14, -21) (Diff)
/intern/libmv/libmv/simple_pipeline/callbacks.h (+1, -1) (Diff)
/intern/libmv/libmv/simple_pipeline/camera_intrinsics.cc (+135, -144) (Diff)
/intern/libmv/libmv/simple_pipeline/camera_intrinsics.h (+51, -53) (Diff)
/intern/libmv/libmv/simple_pipeline/camera_intrinsics_impl.h (+70, -73) (Diff)
/intern/libmv/libmv/simple_pipeline/camera_intrinsics_test.cc (+74, -55) (Diff)
/intern/libmv/libmv/simple_pipeline/detect.cc (+91, -81) (Diff)
/intern/libmv/libmv/simple_pipeline/detect.h (+8, -9) (Diff)
/intern/libmv/libmv/simple_pipeline/detect_test.cc (+9, -10) (Diff)
/intern/libmv/libmv/simple_pipeline/distortion_models.cc (+118, -75) (Diff)
/intern/libmv/libmv/simple_pipeline/distortion_models.h (+64, -65) (Diff)
/intern/libmv/libmv/simple_pipeline/initialize_reconstruction.cc (+21, -21) (Diff)
/intern/libmv/libmv/simple_pipeline/initialize_reconstruction.h (+15, -14) (Diff)
/intern/libmv/libmv/simple_pipeline/intersect.cc (+41, -41) (Diff)
/intern/libmv/libmv/simple_pipeline/intersect.h (+9, -7) (Diff)
/intern/libmv/libmv/simple_pipeline/intersect_test.cc (+10, -8) (Diff)
/intern/libmv/libmv/simple_pipeline/keyframe_selection.cc (+45, -62) (Diff)
/intern/libmv/libmv/simple_pipeline/keyframe_selection.h (+4, -5) (Diff)
/intern/libmv/libmv/simple_pipeline/keyframe_selection_test.cc (+350, -128) (Diff)
/intern/libmv/libmv/simple_pipeline/modal_solver.cc (+30, -29) (Diff)
/intern/libmv/libmv/simple_pipeline/modal_solver.h (+5, -5) (Diff)
/intern/libmv/libmv/simple_pipeline/modal_solver_test.cc (+20, -11) (Diff)
/intern/libmv/libmv/simple_pipeline/packed_intrinsics.h (+9, -9) (Diff)
/intern/libmv/libmv/simple_pipeline/pipeline.cc (+96, -96) (Diff)
/intern/libmv/libmv/simple_pipeline/pipeline.h (+15, -16) (Diff)
/intern/libmv/libmv/simple_pipeline/reconstruction.cc (+34, -33) (Diff)
/intern/libmv/libmv/simple_pipeline/reconstruction.h (+21, -20) (Diff)
/intern/libmv/libmv/simple_pipeline/reconstruction_scale.cc (+3, -3) (Diff)
/intern/libmv/libmv/simple_pipeline/reconstruction_scale.h (+1, -1) (Diff)
/intern/libmv/libmv/simple_pipeline/resect.cc (+42, -38) (Diff)
/intern/libmv/libmv/simple_pipeline/resect.h (+6, -5) (Diff)
/intern/libmv/libmv/simple_pipeline/resect_test.cc (+2, -2) (Diff)
/intern/libmv/libmv/simple_pipeline/tracks.cc (+16, -14) (Diff)
/intern/libmv/libmv/simple_pipeline/tracks.h (+9, -7) (Diff)
/intern/libmv/libmv/threading/threading.h (+1, -1) (Diff)
/intern/libmv/libmv/tracking/brute_region_tracker.cc (+117, -78) (Diff)
/intern/libmv/libmv/tracking/brute_region_tracker.h (+7, -7) (Diff)
/intern/libmv/libmv/tracking/hybrid_region_tracker.cc (+7, -5) (Diff)
/intern/libmv/libmv/tracking/hybrid_region_tracker.h (+10, -9) (Diff)
/intern/libmv/libmv/tracking/kalman_filter.h (+31, -37) (Diff)
/intern/libmv/libmv/tracking/klt_region_tracker.cc (+36, -27) (Diff)
/intern/libmv/libmv/tracking/klt_region_tracker.h (+6, -4) (Diff)
/intern/libmv/libmv/tracking/pyramid_region_tracker.cc (+11, -8) (Diff)
/intern/libmv/libmv/tracking/pyramid_region_tracker.h (+9, -6) (Diff)
/intern/libmv/libmv/tracking/pyramid_region_tracker_test.cc (+4, -6) (Diff)
/intern/libmv/libmv/tracking/region_tracker.h (+6, -4) (Diff)
/intern/libmv/libmv/tracking/retrack_region_tracker.cc (+6, -4) (Diff)
/intern/libmv/libmv/tracking/retrack_region_tracker.h (+9, -6) (Diff)
/intern/libmv/libmv/tracking/track_region.cc (+317, -303) (Diff)
/intern/libmv/libmv/tracking/track_region.h (+20, -14) (Diff)
/intern/libmv/libmv/tracking/trklt_region_tracker.cc (+34, -29) (Diff)
/intern/libmv/libmv/tracking/trklt_region_tracker.h (+6, -4) (Diff)
By: Miika HämäläinenLast update: Nov-07-2014 14:18MiikaHweb | 2003-2021